Share the same switch status object among multiple switch sources.#347
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 83.91% 83.91%
=======================================
Files 125 125
Lines 6741 6741
=======================================
Hits 5657 5657
Misses 1084 1084 Continue to review full report at Codecov.
|
freezy
force-pushed
the
fix/multi-switch-status
branch
from
4432899 to
1c002c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we can have multiple switch mappings pointing to the same switch but a dictionary by switch ID storing the statuses, each switch for the same ID would overwrite the status of the previous one. This PR fixes that by re-using the same status object for all switches of the same ID.